Federal veteran benefits, like VA disability compensation and GI Bill eligibility, are the same no matter where you live. Everything else isn't. States set their own rules for property tax relief, education benefits, hiring preferences, vehicle registration discounts, and more, and those rules vary enough that two veterans with identical service records can end up with meaningfully different benefits just because they live in different states.
This matters most at two decision points: when you're choosing where to claim legal residency while still serving, and when you're deciding where to settle after separation or retirement.